[vlc-devel] [PATCH] WinCE: strip plugin DLLs when creating package

[Rafaël Carré]

On Tue, 3 Nov 2009 22:38:01 +0100
Pierre Ynard <linkfanel at yahoo.fr> wrote:

> This is quite important as plugins quickly fill the memory on WinCE...

It's not a problem of WinCE, it's a problem of the devices with little
RAM which run it. (the explanation can be confusing)

> 
> 
> diff --git a/Makefile.am b/Makefile.am
> index 72271b8..4b4e9a9 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -890,7 +890,7 @@ endif
>  	find vlc-$(VERSION)/sdk.tmp -type d | sort -r | xargs rmdir
>  	rm -Rf vlc-$(VERSION)/sdk/bin
>  
> -#strip exe and main dll
> +# Strip DLLs
>  package-win-common-strip: package-win32-base-debug
>  	@if test -e "$(win32_debugdir)"; then \
>  	  echo "Error: please remove $(win32_debugdir), it is in the
> way"; \ @@ -898,23 +898,18 @@ package-win-common-strip:
> package-win32-base-debug else \
>  	  echo "OK."; mkdir -p "$(win32_debugdir)"; \
>  	fi
> -	for i in "" vlc-$(VERSION)/*$(LIBEXT) ; \
> -      do if test -n "$$i" ; then \
> -      $(OBJCOPY) --only-keep-debug "$$i" "$$i.dbg"; \
> -      $(OBJCOPY) --strip-all "$$i" ; \
> -      $(OBJCOPY) --add-gnu-debuglink="$$i.dbg" "$$i" ; \
> -	  mv "$$i.dbg" "$(win32_debugdir)"; \
> -    fi; done
> -
> -#strip all plugins dll
> +	for i in "" $(win32_destdir)/*$(LIBEXT) \
> +                    $(win32_destdir)/plugins/*$(LIBEXT) \
> +	; do \
> +	  if test -n "$$i" ; then \
> +	    $(OBJCOPY) --only-keep-debug "$$i" "$$i.dbg"; \
> +	    $(OBJCOPY) --strip-all "$$i" ; \
> +	    $(OBJCOPY) --add-gnu-debuglink="$$i.dbg" "$$i" ; \
> +	    mv "$$i.dbg" "$(win32_debugdir)"; \
> +	  fi ; \
> +	done
> +
>  package-win32-base: package-win-common-strip
> -	for i in "" $(win32_destdir)/plugins/*$(LIBEXT) ; \
> -	  do if test -n "$$i" ; then \
> -	  $(OBJCOPY) --only-keep-debug "$$i" "$$i.dbg"; \
> -	  $(OBJCOPY) --strip-all "$$i" ; \
> -	  $(OBJCOPY) --add-gnu-debuglink="$$i.dbg" "$$i" ; \
> -	  mv "$$i.dbg" "$(win32_debugdir)"; \
> -	fi ; done
>  
>  package-win32-base-exe: package-win32-base
>  # Create package
> @@ -980,13 +975,14 @@ package-win32-debug:
> package-win32-base-debug-zip package-win32-base-debug-7zip # Clean up
>  	rm -Rf $(win32_destdir)
>  
> -package-wince-base: package-win-common package-win-common-strip
> +package-wince-base: package-win-common-strip
>  
> -package-wince-base-zip:
> +package-wince-base-zip: package-wince-base
>  # Create package 
> -	zip -r vlc-$(VERSION)-wince.zip vlc-$(VERSION)
> +	rm -f -- vlc-$(VERSION)-wince.zip
> +	zip -r -9 vlc-$(VERSION)-wince.zip vlc-$(VERSION)
>  
> -package-wince: package-wince-base  package-wince-base-zip
> +package-wince: package-wince-base-zip
>  # Clean up
>  	rm -Rf $(win32_destdir)
> 
> ---

Ok, please commit (with a clearer message)

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091103/77ce5f21/attachment.sig>