[vlc-devel] commit: Qt4: remove incorrect use of EQ callbacks ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Nov  7 16:56:21 2009 +0200| [5a95ab4f3902da23bc01d0de415840e8986ceea1] | committer: Rémi Denis-Courmont 

Qt4: remove incorrect use of EQ callbacks

 * deleting non-existent callback is not allowed (-> abort),
 * adding a callback but not deleting it is a bad idea,
 * deleting a callback while setting the valeu can race against other
   interfaces.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5a95ab4f3902da23bc01d0de415840e8986ceea1
---

 modules/gui/qt4/components/extended_panels.cpp |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/modules/gui/qt4/components/extended_panels.cpp b/modules/gui/qt4/components/extended_panels.cpp
index 045c245..2408784 100644
--- a/modules/gui/qt4/components/extended_panels.cpp
+++ b/modules/gui/qt4/components/extended_panels.cpp
@@ -1054,13 +1054,11 @@ void Equalizer::setCorePreset( int i_preset )
     aout_instance_t *p_aout= THEMIM->getAout();
     if( p_aout )
     {
-        delCallbacks( p_aout );
         var_SetString( p_aout , "equalizer-preset" , preset_list[i_preset] );
 
         var_SetString( p_aout, "equalizer-bands", psz_values );
         var_SetFloat( p_aout, "equalizer-preamp",
                       eqz_preset_10b[i_preset]->f_preamp );
-        addCallbacks( p_aout );
         vlc_object_release( p_aout );
     }
     config_PutPsz( p_intf, "equalizer-bands", psz_values );