[vlc-devel] [PATCH] Prepared statements for SQL

[Srikanth Raju]

Hi,

Everything is fixed. Patch attached.

On Tue, Nov 10, 2009 at 4:36 AM, Laurent Aimar <fenrir at via.ecp.fr> wrote:

> Hi,
>
> On Fri, Nov 06, 2009, Srikanth Raju wrote:
> >    I did this. But it seems to make the include a lot heavier. Not too
> heavy
> >    though.
>  If it is a problem, they could be moved to the core (later is fine).
>
> > +#include <assert.h>
>  Sadly, it is a bad idea to include <assert.h> in a public header, and
> so you should remove it.
>
> > +typedef struct sql_stmt_sys_t sql_stmt_sys_t;
> Useless.
>
> >      /** Rollback transaction */
> >      int (*pf_rollback) ( sql_t* );
> In the current commited file, it is void and not int. It prevents me to
> apply the patch.
>
> > +struct sql_stmt_t;
> Useless.
>
> >
>  /*****************************************************************************
> >   * SQL Function headers
> > @@ -249,6 +305,267 @@ static inline int sql_RollbackTransaction( sql_t
> *p_sql )
> Same here, void instead of it.
>
> > +static inline int sql_GetColumnInteger( sql_t* p_sql, sql_stmt_t*
> p_stmt,
> > +        int i_col, int* i_res )
> > +{
> > +    assert( i_res != NULL );
>  You will need to removes the assert()
>
>  Otherwise, the patch is fine (I would have applied it, but because of
> rollback() and assert(), I prefered not to modify your patch myself).
>
> Regards,
>
> --
> fenrir
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Regards,
Srikanth Raju
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091110/b8812c3a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Sql-Include-interface-for-prepared-statements.patch
Type: application/octet-stream
Size: 14300 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091110/b8812c3a/attachment.obj>