[vlc-devel] [PATCH] GSoC: lua services discovery, core part

[Jakob Leben]

2009/11/11 Rémi Denis-Courmont <remi at remlab.net>

>
> On Wed, 11 Nov 2009 01:13:34 +0100, Fabio Ritrovato
> <exsephiroth87 at gmail.com> wrote:
> > On Wed, Nov 11, 2009 at 12:07 AM, Jakob Leben <jakob.leben at gmail.com>
> > wrote:
> >> If the function covers all kinds of requests, why don't we use that same
> >> function for item-delete requests and item-get requests? I must join the
> >> opinion that this is somewhat inconsistent.
> >
> > Well, i guess you have a point, I just thought it was better to have 3
> > different functions than a big one to handle everything with a
> > parameter to decide what to do...
>
> In fact, separate functions are probably better. Otherwise, we+ ll just end
> up multiplexing on the caller side and demultiplexing on the callee side,
> which is a waste of both developer and CPU time.
>

I agree, my post was a bit ironic, sorry. I meant that the "put" interface
could in a way be more elaborate, to _reduce_ demultiplexing and make
explicit various meanings the function might have. For example: to avoid a
part of demultiplexing, the function could take arguments like:
( services_discovery_t *, const char * psz_request_type, const char
*psz_request_data )

... Or on the other hand: why should the data necessarily be char*? what
about void*?

Anyway, it being so vague, we don't profit much over leaving the plugin
specific stuff to plugins and use var_Get/Set on plugin-created variables.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091112/974b3bb8/attachment.html>