[vlc-devel] [PATCH 02/10] Extensions: Lua implementation for dialogs

[Jean-Philippe André]

Friday 13 November 2009, 13:36:02,
Rémi Denis-Courmont wrote:
> > New vlc.dialog library, that allows users to create scriptable dialogs.
> > Works only when used with extensions (see following commits).
> 
> I have not looked much at the rest, but the delete function smells really
> bad code:
> - interval polling,
> - waiting on a condition variable without a predicate.

Yes, I agree with you that vlclua_dialog_delete is not perfect. I have to 
admit I didn't really know how to manage this dialog destruction. The current 
solution is some kind of a work around, as you can see.

The idea was that I don't trust the interface will properly destroy the dialog 
in time. I can investigate it further though...

Best regards,

-- 
Jean-Philippe André (jpeg)