[vlc-devel] commit: contrib: crappy patch to build libmpeg2 on WinCE (Pierre Ynard )

[Rémi Denis-Courmont]

Le samedi 14 novembre 2009 04:58:14 git version control, vous avez écrit :
> vlc | branch: master | Pierre Ynard <linkfanel at yahoo.fr> | Sat Nov 14
>  03:42:26 2009 +0100| [1e756a835e2fddd883b8475fe3b8f87230781163] |
>  committer: Pierre Ynard
> 
> contrib: crappy patch to build libmpeg2 on WinCE
> 
> Devices running WinCE don't necessarily support the pld ARM instruction,
> which prevents libmpeg2 from building. This patch unconditionally
> removes that instruction on WinCE.

PLD requires ARMv5T, so it's missing from ARMv4. IMHO it's highly questionable 
that you'd want to decode MPEG2 video on such on old (slow) CPU. So I'd say it 
makes more sense to explicit build libmpeg2 against ARMv5, and prevent protect 
the libmpeg2 VLC plugin with a CPU capability.

In any case, HAVE_WINCE seems wrong here.

-- 
Rémi Denis-Courmont
http://www.remlab.net/