[vlc-devel] [PATCH]

Rémi Denis-Courmont remi at remlab.net
Sat Nov 14 11:22:03 CET 2009


Le vendredi 13 novembre 2009 21:39:41 ht6690 ht6690, vous avez écrit :
> The first patch consists of checks being added to certain files in the case
>  of realloc failing and also keeps the same behaviour as without the patch.
>  This patch does not solve the problem of failing (i.e quit when a
>  allocation is unsuccessful) it is merely a start highlighting the realloc
>  failing points for future fixes.

It makes more sense to ignore the error if and only if the new allocation size 
is lower or equal to the old one, and abort() otherwise. Your current patch 
introduces heap overflows. I think that's much worse than the current 
behaviour whereby VLC will trigger a 'clean' segmentation fault at address 0.

Rémi Denis-Courmont

More information about the vlc-devel mailing list