[vlc-devel] [PATCH] V4L for FreeBSD userland libv4l{1, 2} wrapper library

[Buganini]

On Tue, Nov 17, 2009 at 10:55 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
> On Tue, 17 Nov 2009 22:51:54 +0800
> Buganini <buganini at gmail.com> wrote:
>
>> On Tue, Nov 17, 2009 at 10:05 PM, Rafaël Carré
>> <rafael.carre at gmail.com> wrote:
>> > Why not the same way the other function pointers are stored? (as
>> > p_sys members)
>>
>> http://zeta.twbbs.org/~buganini/vlc/1.0001-v4l2-use-v4l2_open-for-use-of-libv4l2.patch
>
> Hm you didn't test your change!

huh..
http://zeta.twbbs.org/~buganini/vlc/2.0001-v4l2-use-v4l2_open-for-use-of-libv4l2.patch
if you need it.

>
> You mixed v4l_open() and v4l2_open()
>
>> > I asked this more to know if v4l2 is available with kernel
>> > open/ioctl, and I see it's available so the code will be the same
>> > for Linux / FreeBSD
>>
>
> If v4l2 can't be used in "kernel mode" then the use_kernel_v4l2 case
> should be commented out for FreeBSD.
>
> If you prefer I can do this part

ok, thanks

it use_libv4l2 if use_kernel_v4l2 fail, so I didnt change it.
but also good to eliminate err msg.


--Buganini