[vlc-devel] [PATCH] V4L for FreeBSD userland libv4l{1, 2} wrapper library

Rémi Denis-Courmont remi at remlab.net
Wed Nov 18 11:30:19 CET 2009


On Wed, 18 Nov 2009 17:27:00 +0800, Buganini <buganini at gmail.com> wrote:
> 2009/11/17 Rémi Denis-Courmont <remi at remlab.net>:
>> Do those functions set the close-on-exec flag? If not, you may have a
> problem
>> (because VLC does fork-and-exec in other threads).
> 
> No, I think, there is no FD_CLOEXEC in source code.

Then your patch is wrong. That's why we use(d) utf8_open() instead of
open() here.

Besides, FD_CLOEXEC is not sufficient. You need to create the file
descriptor with close-on-exec flag. On Linux, there is O_CLOEXEC for this.
Don't know about FBSD.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list