[vlc-devel] [PATCH] Reverbation Files

[Rafaël Carré]

On Tue, 24 Nov 2009 21:09:28 +0800
wangxiang <wangxiang68 at gmail.com> wrote:

Hi, some little remarks:

> From ffa0d7f475e4d7797eee95f4834916d4a7601589 Mon Sep 17 00:00:00 2001
> From: richard <xwang at xwang-laptop.(none)>

Please check your git config

> +SOURCES_spatializer = reverbation.cpp \

You probably means SOURCES_reverberation

btw this module should be added to configure.ac


> diff --git a/modules/audio_filter/reverbation/all-pass.cpp
           Should be reverbERation  ^^^^^^^^^^^

I didn't check the code I'll let someone else do that, but I noticed
the Cleanup() functions weren't called? If they are destructors then
shouldn't they go in the destructor ?

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091124/1db65814/attachment.sig>