[vlc-devel] commit: module_EndBank: useless NULL assignments ( Rémi Denis-Courmont )

git version control git at videolan.org
Tue Nov 24 18:13:59 CET 2009


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov 24 19:13:32 2009 +0200| [5df21676ae2d47e04f4d37f3b23c2defc5d8b0d4] | committer: Rémi Denis-Courmont 

module_EndBank: useless NULL assignments

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5df21676ae2d47e04f4d37f3b23c2defc5d8b0d4
---

 src/modules/modules.c |   14 ++------------
 1 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/modules/modules.c b/src/modules/modules.c
index 3f75013..ddb2b4b 100644
--- a/src/modules/modules.c
+++ b/src/modules/modules.c
@@ -196,25 +196,15 @@ void module_EndBank( vlc_object_t *p_this, bool b_plugins )
                     p_bank->pp_loaded_cache[p_bank->i_loaded_cache]->p_module );
             free( p_bank->pp_loaded_cache[p_bank->i_loaded_cache]->psz_file );
             free( p_bank->pp_loaded_cache[p_bank->i_loaded_cache] );
-            p_bank->pp_loaded_cache[p_bank->i_loaded_cache] = NULL;
         }
     }
-    if( p_bank->pp_loaded_cache )
-    {
-        free( p_bank->pp_loaded_cache );
-        p_bank->pp_loaded_cache = NULL;
-    }
+    free( p_bank->pp_loaded_cache );
     while( p_bank->i_cache-- )
     {
         free( p_bank->pp_cache[p_bank->i_cache]->psz_file );
         free( p_bank->pp_cache[p_bank->i_cache] );
-        p_bank->pp_cache[p_bank->i_cache] = NULL;
-    }
-    if( p_bank->pp_cache )
-    {
-        free( p_bank->pp_cache );
-        p_bank->pp_cache = NULL;
     }
+    free( p_bank->pp_cache );
 #endif
 
     while( p_bank->head != NULL )




More information about the vlc-devel mailing list