[vlc-devel] [PATCH] SQLite module

Rémi Denis-Courmont remi at remlab.net
Wed Nov 25 13:06:44 CET 2009


On Wed, 25 Nov 2009 17:01:55 +0530, Srikanth Raju <srikiraju at gmail.com>
wrote:
>> I fail to see a problem here. I never said you should expose SQLite
>> typedefs outside.
> 
> 
> typedef sqlite3_stmt sql_stmt_t; doesn't work as it conflicts with the
> typedef from vlc_sql.h
> Should I do #define sql_stmt_t sqlite3_stmt, it makes a lot of warnings

You could cast explicitly (possibly through macros). Then again, I think
Laurent does not like this. Lets forget about that for now.

>> What's wrong with using sqlite3_free() directly _after_ you are done?
>>
> 
> API user doesn't know about sqlite3_free()

Because you did not provide a custom free function in the API. But is there
a fundamental reason why you couldn't do that?

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list