[vlc-devel] [PATCH] SQLite module

[Srikanth Raju]

2009/11/27 Rémi Denis-Courmont <remi at remlab.net>

> Le vendredi 27 novembre 2009 05:10:26 Srikanth Raju, vous avez écrit :
> > Hi,
> >
> > First patch is to fix the core definition of RollbackTransaction.
> >
> > I fixed the Rollback issue by including a busy handler which retries the
> > failed rollback( and any other statements that failed due to Busy errors
> ).
> > There is a test when opening the database to check if the library is
> > threadsafe.
>
> Shouldn't the thread safety test be made before opening the DB?

Correct. Done.


> Are both locks
> still needed?
>
> Yup. Threadsafety in sqlite is only on a connection basis. So only if there
are many connections to sqlite, it will be threadsafe. Using the regular
lock will serialise access through a single connection in vlc.


> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Regards,
Srikanth Raju
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091128/2e687e39/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Sql-Rollback-should-return-void.patch
Type: text/x-diff
Size: 1039 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091128/2e687e39/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Sqlite-Module.patch
Type: text/x-diff
Size: 27309 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091128/2e687e39/attachment-0001.patch>