[vlc-devel] commit: mmap: default enable the module on Darwin ( Felix Paul Kühne )

[Laurent Aimar]

Hi,

On Wed, Sep 30, 2009, git version control wrote:
> vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Wed Sep 30 14:39:02 2009 +0200| [15071afcbd9160efe73a4df9ae30e838f6c35ebf] | committer: Felix Paul Kühne 
> 
> mmap: default enable the module on Darwin
 I think it is a bad idea.
 mmap will issue a SIGBUS if we try to read the file if it has been
truncated for example.

 From, irc, you implied that it helps performances (why not) and allows
to reach back the level of perf of 0.8.6. Unless I am wrong, 0.8.6 doesn't
use it, and so you are probably hidding a bug/regression.

-- 
fenrir