[vlc-devel] [Patch][GSoC:2009] wiimote module

[Anthony Loiseau]

Hi,

There is some tabs in your patch, at least in intf_sys_t and
BATTERY_STR_LEN definition.

Also, if you chose to use dialog_* calls later, you will not want to
really remove your msg_Err call. "dialog_.*Create" can return null, in
which case it is interesting to fallback on msg_Err call.


Regards,
Anthony

On Thu, 2009-10-01 at 17:57 -0500, Leon Moctezuma wrote:
> Hi all,
> 
> here is a new patch with some small changes...
> 
> On 10/1/09, Leon Moctezuma <densedev at gmail.com> wrote:
> >>
> >> +static void Close( vlc_object_t *p_this )
> >> +{
> >> +    intf_thread_t *p_intf = (intf_thread_t *)p_this;
> >> +    intf_sys_t *p_sys = p_intf->p_sys;
> >> +
> >> +    free( p_sys );
> >> +}
> >>
> >> How is this unregistering from libcwiid?
> >>
> >>
> > Oh I think, I'm missing a cwiid_close(p_sys->p_wiimote), thanks.
> >
> >
> >>
> >> +    msg_Err(p_intf, "Put Wiimote in discoverable mode (press 1+2) to
> >> connect
> >> it...\n");
> >>
> >> This should probably use on of the dialog_*() function. Most users won't
> >> see
> >> the VLC messages console.
> >>
> >>
> > Totally true, I just did it that way, because i don't know how to send such
> > dialog from the wiimote module, if you can tell how, I will modify it :P.
> >
> > --
> > León Moctezuma
> >