[vlc-devel] [PATCH 16/23] Revert "Increased fifo decoder size to 400mb."

Rémi Denis-Courmont remi at remlab.net
Sat Oct 3 19:52:23 CEST 2009


This reverts commit c1ec23d7b27a1f3f34a10b4c38169a7903cbe302.
400MB buffers were practically freezing systems due to eavy thrashing.
Not everyone has 1GB of RAM. Please do not do this.
---
 src/input/decoder.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/input/decoder.c b/src/input/decoder.c
index 8385422..e81f0d9 100644
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -373,7 +373,7 @@ void input_DecoderDecode( decoder_t *p_dec, block_t *p_block, bool b_do_pace )
         if( !p_owner->b_buffering )
             block_FifoPace( p_owner->p_fifo, 10, SIZE_MAX );
     }
-    else if( block_FifoSize( p_owner->p_fifo ) > 400000000 /* 400 MB, ie ~ 50mb/s for 60s */ )
+    else if( block_FifoSize( p_owner->p_fifo ) > 50000000 /* 50 MB */ )
     {
         /* FIXME: ideally we would check the time amount of data
          * in the FIFO instead of its size. */
-- 
1.6.4.3




More information about the vlc-devel mailing list