[vlc-devel] [RFC] [PATCH 00/23] Nokia N900 tweaks

[Rafaël Carré]

Le 03/10/2009 19:47, Rémi Denis-Courmont a écrit :
> 	Hello allo,
> 
> This patchset provides support for Nokia N900. It sits on top of the
> current VLC master branch. Unfortunately, many of them are too hackish
> in their current state for direct application. But I'm not sure how I
> should clean them up so that they become acceptable.
> 
> Comments welcome.

Some hacks could be made conditional assuming we are building for N900.

I have started thinking about how to enable machine-specific hacks while
working on porting 0.8.6-neuros code (for TI davinci dm6446) to master.

Right now we have code for N770, and soon for N900 and DM6446.

We must be able to make assumptions on the hardware from the code so I
suggest something like:

./configure --enable-machine=n900

in configure.ac:

if test ${machine} = "n900"; then
    add_cflags([-DMACHINE_N900])
elif test ${machine} = "n770"; then
    add_cflags([-DMACHINE_N770])
    vlc_add_plugins([maemo_swscale])
fi

in modules/foo/bar.c
#ifdef MACHINE_N900
bla
#else
bar
#endif


Then I see you modified some options inside libvlc-module.c

I answered to this patch with a suggestion : having profiles for
different defaults, conditional on the machine type.


Did you have something else in mind?

HTH,

-- 
Rafaël Carré

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091003/99ca262d/attachment.sig>