[vlc-devel] [LATTE] Totally broken playlist in 1.0.2

[Rémi Denis-Courmont]

Le dimanche 4 octobre 2009 10:13:41 Rémi Denis-Courmont, vous avez écrit :
> Can anyone tell me they were thinking when they patched the Qt4 playlist
>  code in the bugfix branch. Reordering files with drag&drop does not work
>  anymore. Sorting crashes immediately. I have Qt4 1.5.2 so don't even try
>  to invoke the "buggy Qt4 version" excuse.

Sorting crash is caused by:

cd76d8a9123fefc65643404452e794a5b817f803 is the first bad commit
commit cd76d8a9123fefc65643404452e794a5b817f803
Author: Ilkka Ollakka <ileoo at videolan.org>
Date:   Fri Jul 31 13:36:58 2009 +0300

    QT4: set sorting-connections by hand

    Thisway playlist don't run sort when created (in case of you start vlc,
    and don't set playlist visible then adding stuff. When you open playlist
    it would sort the stuff).

    Also remove showing sort-indicator incorrectly on start (don't show
    it at all before user clicks to sort).

:040000 040000 43c2941c18a9720fc2a58daf425fcac8544f14a8 
3fb78530507183dc6379c7a1227d8c313104ae2f M      modules

Evidently, the backport was not tested at all, since the same commit works 
fine in master...

-- 
Rémi Denis-Courmont
http://www.remlab.net/