[vlc-devel] commit: strerror(errno) is not thread-safe, use %m ( Rémi Denis-Courmont )

[Rafael Carre]

Le Wed, 07 Oct 2009 10:11:05 +0200,
Anthony Loiseau <thannoy at actech-innovation.com> a écrit :

> Hi,
> 
> Just a note (I have not tested anything).
> - strerror() conforms to C89,C99 and POSIX

sure, but it just is not thread safe so you shouldn't use it in VLC


> - isn't %m a GNU extension?

Yes but VLC emulates it : see QueueMsg() in src/misc/messages.c

> So I wonder to know if %m works when compiling for Windows or other
> targets. Also, maybe those files are only used on compliant targets, I
> don't know.

It does work

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091007/a86de7eb/attachment.sig>