[vlc-devel] commit: Revert "RTP: compute deadline for reordering from the current time" ( Rémi Denis -Courmont )

Marian Ďurkovič md at bts.sk
Thu Oct 15 08:05:18 CEST 2009

On Wed, 14 Oct 2009 22:11:11 +0300, Rémi Denis-Courmont wrote
> git version control wrote:
> > vlc | branch: 1.0-bugfix | Rémi Denis-Courmont <remi at remlab.net> | Wed Oct
14 21:59:35 2009 +0300| [af7f57911b20990a6d1423fda5f39f8eb6674da0] | committer:
Rémi Denis-Courmont 
> > 
> > Revert "RTP: compute deadline for reordering from the current time"
> > 
> > This reverts commit 474ef3f0c956b2a4acc0511bd81204fad0987d5b.
> > This broke RTP caching completely in 1.0.2.
> Tested with a simple MP3 stream and no reordering.
> There is no excuse in such a trivial case.

Well, *BEFORE* you revert commits which are desperately needed for proper
MPEG-TS over RTP operation, you could at least present the problem to the
vlc-devel for discussion. I suppose the only change that was fixing the problem
is this:

-    block->i_pts = CLOCK_FREQ * timestamp / pt->frequency;
+    block->i_pts = UINT64_C(1) * CLOCK_FREQ * timestamp / pt->frequency; 

as nothing else from the reverted code is anyhow relevant when no reordering
takes place.

In fact, the real problem is in include/vlc_config.h:

-#define CLOCK_FREQ 1000000
+#define CLOCK_FREQ INT64_C(1000000)

which wasn't backported from master yet.

   With kind regards,


More information about the vlc-devel mailing list