[vlc-devel] commit: Revert "RTP: compute deadline for reordering from the current time" ( Rémi Denis -Courmont )
md at bts.sk
Thu Oct 15 10:50:32 CEST 2009
On Thu, Oct 15, 2009 at 10:05:27AM +0200, Rémi Denis-Courmont wrote:
> On Thu, 15 Oct 2009 08:05:18 +0200, "Marian Ďurkovič" <md at bts.sk> wrote:
> > In fact, the real problem is in include/vlc_config.h:
> > -#define CLOCK_FREQ 1000000
> > +#define CLOCK_FREQ INT64_C(1000000)
> > which wasn't backported from master yet.
> Backporting stuff correctly is the responsibility of whoever commits - in
> other words, *your* job. I spent several hours of my free time bisecting
> the issue, that's already too much. I have better things to do than clean
> up after other people who don't test their backports properly.
It was tested, but with MPEG-TS which didn't exhibit the problem...
Anyway, I don't feel safe backporting the above as CLOCK_FREQ is used
in many places, so for now I just put back the "UINT64_C(1) *" workaround.
OTOH, it always makes sense to report problems to all committers, since
someone might have an idea even without the need for bisecting.
With kind regards,
More information about the vlc-devel