[vlc-devel] commit: Subtitles detection: decode before testing the files. ( Jean-Baptiste Kempf )

[Rémi Denis-Courmont]

Le dimanche 18 octobre 2009 00:56:11 Rafaël Carré, vous avez écrit :
> Le 17/10/2009 23:53, git version control a écrit :
> > vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Sat Oct 17
> > 23:48:45 2009 +0200| [323f59ac8be30d79bbb1f15cb3d089163dd08aef] |
> > committer: Jean-Baptiste Kempf
> >
> > Subtitles detection: decode before testing the files.
> >
> > This calls decode_URI, as does the meta.c file. I hope this is correct,
> > feel free to revert if not. closes #3076
> >
> > +    const char *psz_fname = decode_URI( psz_name_org );
> >      if( !strncmp( psz_fname, "file://", 7 ) )
> 
> decode_URI() only decodes components

Yes.

> (the part after XXX://)

No.

The part after the scheme is made of multiple optional components: an 
username, a password, a hostname, a port nomber, directory names, a file name, 
query parameters (not possible for the file scheme) and an anchor.

For example
file://john:asdfg@server.example.com/dir1/dir2/My%20file.html#here
includes the following components:
 - file: URI scheme,
 - john: user name,
 - asdfg: password,
 - server.example.com: hostname,
 - dir1: top level directory,
 - dir2: subdirectory,
 - My file.html: file name,
 - here: anchor in the HTML file.


-- 
Rémi Denis-Courmont
http://www.remlab.net/