[vlc-devel] Bug During Upgrade with Windows Installer with /S

[Neil M.]

When using the /S install option, the installer should not show any
prompts.  When upgrading only (installing with an already existing
version in place) a dialog appears asking what to do with the old
install.  I found the problem in v1.0.2 on line 721 in vlc.win32.nsi.in:

MessageBox MB_YESNO|MB_ICONEXCLAMATION $Message_AlreadyInstalled IDNO done

I propose this line is changed to:

MessageBox MB_YESNO|MB_ICONEXCLAMATION $Message_AlreadyInstalled /SD
IDYES IDNO done

See: http://nsis.sourceforge.net/Docs/Chapter4.html#4.12

Thank you.

Neil