[vlc-devel] commit: video_filter_puzzle: remove unnedeed structure ( it does not change anything to the race conditions already present). ( Rémi Duraffort )

Rémi Duraffort ivoire at videolan.org
Tue Oct 20 19:38:18 CEST 2009

In fact inside the Mouse function the lock is not taken while modifying
the p_sys structure and even more modifying the pi_order array. AFAIK
this can lead to a segv.
I'm not sure this commit was really needed but there is definitivelly a
race condition here.

The question is maybe more: is it needed to use a lock when writing to a
member of p_sys inside a callback if this variable is only written
inside this callback and read only in the filter function ?
We might have a race condtion if the write and read happen in the same
time but the value will be ok for the next frame.

Rémi Duraffort | ivoire

More information about the vlc-devel mailing list