[vlc-devel] [PATCH] Added alang option to transcode

Rémi Denis-Courmont remi at remlab.net
Fri Oct 23 11:58:38 CEST 2009


On Thu, 22 Oct 2009 15:35:20 -0400, "Mat King" <mking at trilithic.com> wrote:
> +    add_string( SOUT_CFG_PREFIX "alang", NULL, NULL, ALANG_TEXT,
> +                ALANG_LONGTEXT, false )
                                   ^^^^^
I think it should be 'true' here.

> +    var_Get( p_stream, SOUT_CFG_PREFIX "alang", &val );
> +    p_sys->psz_alang = NULL;
> +    if( val.psz_string && *val.psz_string )
> +    {
> +        char *psz_next;
> +        psz_next = config_ChainCreate( &p_sys->psz_alang,
> &p_sys->p_audio_cfg,
> +                                       val.psz_string );
> +        free( psz_next );
> +    }
> +    free( val.psz_string );

Could this whole block not be replaced with just:
    p_sys->psz_along = var_GetNonEmptyString( p_stream,
SOUT_CFG_PREFIX"alang" );
?

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list