[vlc-devel] commit: Implement TDT parsing in TS demux. ( Marian Ďurkovič )

[Marian Ďurkovič]

On Thu, Oct 29, 2009 at 03:12:24PM +0000, Christophe Mutricy wrote:
> Hello
> 
> 2009/10/29 git version control <git at videolan.org>:
> 
> > --- a/modules/demux/ts.c
> > +++ b/modules/demux/ts.c
> > @@ -77,6 +77,17 @@
> 
> > +/* TDT support */
> > +#ifdef _DVBPSI_TOT_H_
> [...]
> > +#       include "tables/tot.h"
> > +#endif
> 
> Without having thoroughlu checked libdvpsi headers, it feels quite suspicious.
> 
> Typically _DVBPSI_TOT_H_ will be defined in tot.h to avoid double inclusion.
> 
> Did you meant to test for it in configure and use #ifdef HAVE_DVBPSI_TOT_H  ?

This symbol means we have tot.h in dvbpsi i.e. TDT/TOT parsing is available.
Older libdvbpsi versions don't have this header.

I don't think it's necessary to check for it in configure, in fact EIT
support is tested the same way in ts.c:

/* EIT support */
#ifdef _DVBPSI_DR_4D_H_

BTW, the #ifdefs should ensure the code compiles and works with any
libdvbpsi version, but when TDT parsing is not available, it will
use time() /i.e. the local clock/ and not TDT time from the stream.


    With kind regards,

           M.