[vlc-devel] commit: Don't release an object that was not held, fix crash ( Rémi Denis-Courmont )

git version control git at videolan.org
Thu Oct 29 17:56:25 CET 2009


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Oct 29 18:52:32 2009 +0200| [aeaf15c3bee2514e8722f6207301deb3ad65bb07] | committer: Rémi Denis-Courmont 

Don't release an object that was not held, fix crash

This piece of code (transparent UTF-16 to UTF-8 conversion) is wrong in
many ways though. This really does NOT belong here, and should be done
in the subsdec plugin instead.

This fixes a regression from [0d1f966a0b3581d3e96423ce34f32b4da7725c31]

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=aeaf15c3bee2514e8722f6207301deb3ad65bb07
---

 src/input/stream.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/input/stream.c b/src/input/stream.c
index e97e586..b656822 100644
--- a/src/input/stream.c
+++ b/src/input/stream.c
@@ -1547,7 +1547,6 @@ char *stream_ReadLine( stream_t *s )
                 {
                     var_Create( p_input, "subsdec-encoding", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
                     var_SetString( p_input, "subsdec-encoding", "UTF-8" );
-                    vlc_object_release( p_input );
                 }
             }
         }




More information about the vlc-devel mailing list