[vlc-devel] Win64 patch and format

Rafaël Carré rafael.carre at gmail.com
Wed Sep 2 16:38:13 CEST 2009


On Wed, 2 Sep 2009 16:29:54 +0200
Jean-Baptiste Kempf <jb at videolan.org> wrote:

> On Wed, Sep 02, 2009 at 04:25:08PM +0200, Rafaël Carré wrote :
> > > +#if defined( _WIN64 ) && defined( __USE_MINGW_ANSI_STDIO )
> > > + #undef PRId64
> > > + #define PRId64 "lld"
> > > + #undef PRIi64
> > > + #define PRIi64 "lli"
> > > + #undef PRIu64
> > > + #define PRIu64 "llu"
> > > +#endif
> > Where and to what were those defined before you undef them (in
> > inttypes.h ?)
> 
> "I64d" "I64i" "I64u"

Looks weird to me

> > FOR PRI* IT COULD BE THE MINGW HEADERS? I DONT KNOW WE NEED TO CHECK
> A feature request has been put for mingw upstream.

Do you have a link ?

If the headers are buggy and we want to fix them in vlc_common.h we
should check their version, not
#if defined( _WIN64 ) && defined( __USE_MINGW_ANSI_STDIO )

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090902/8668c37f/attachment.sig>


More information about the vlc-devel mailing list