[vlc-devel] [PATCH] Added window roles for X11

[Nick Pope]

Jean-Baptiste Kempf wrote:
> On Wed, Sep 02, 2009 at 07:30:44PM +0300, Rémi Denis-Courmont wrote :
>   
>> Le mercredi 2 septembre 2009 19:14:20 Nick Pope, vous avez écrit :
>>     
>>> Can you think of anything further to add regarding this?  And if it is
>>> fine is someone able to commit it?
>>>       
>> It's fine with me, but JB seems to imply that this would break Windows 
>> compilation.
>>     
> Sorry, that was not what I meant.
> I just said that as this is useless on Windows, we could skip it, since
> Qt folks don't seem to remove it on Win32
I don't really think it is necessary.  I don't know what the internal 
behaviour of Qt compiled for Win32 is regarding setWindowRole().  I 
would presume that it just does a no-op as their documentation states 
that setWindowRole() is for X11 only.  I am not able to compile it for 
Win32 right now, I'm afraid, so I can't test - I would think that it 
will just work fine, otherwise it would break cross-platform 
compatibility as far as the Qt library is concerned.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090902/fe342eed/attachment.html>