[vlc-devel] audio output bug report

[Rafaël Carré]

On Thu, 03 Sep 2009 11:32:31 +0200
Sébastien Escudier <sebastien-devel at celeos.eu> wrote:

> Quoting Rafaël Carré <rafael.carre at gmail.com>:
> 
> > On Thu, 03 Sep 2009 11:15:11 +0200
> > Sébastien Escudier <sebastien-devel at celeos.eu> wrote:
> >
> > Hi, does it crash with other audio output than "dummy" ?
> 
> aout_file does not crash.

I have tried to make the buffer allocation more clear in the latest
commits, and continuing testing with dummy aout I found this:

in src/audio_output/mixer.c MixBuffer(): (// are my comments)

    aout_BufferAlloc( &p_aout->p_mixer->allocation,
                      ((uint64_t)p_aout->output.i_nb_samples * 1000000)
                        / p_aout->output.output.i_rate,
                      /* This is a bit kludgy, but is actually only used
                       * for the S/PDIF dummy mixer : */
                      p_aout->pp_inputs[i_first_input]->mixer.fifo.p_first,
                      &p_output_buffer );

//p_output_buffer = p_aout->pp_inputs[i_first_input]->mixer.fifo.p_first

...
//  modules/audio_mixer/spdif.c DoWork()
    p_aout->p_mixer->mix( p_aout->p_mixer, p_output_buffer );
// will free all buffers, starting from the first in fifo, so
// p_output_buffer is freed as well

...

    aout_OutputPlay( p_aout, p_output_buffer );
// will free p_output_buffer one more time

I don't quite understand yet the picture of audio outputs and mixers so
I don't know how to fix this.

Not sure what is the aim of "Dummy S/PDIF audio mixer" either, removing
the module gives a segfault (well, now an assertion failure).

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090903/07292209/attachment.sig>