[vlc-devel] commit: Remove unused alloca.h, add an assertion ( Rafaël Carré )

[Rafaël Carré]

On Thu, 3 Sep 2009 17:19:26 +0200
Laurent Aimar <fenrir at via.ecp.fr> wrote:

> On Thu, Sep 03, 2009, Rafaël Carré wrote:
> > On Thu, 3 Sep 2009 16:37:16 +0200
> > Laurent Aimar <fenrir at via.ecp.fr> wrote:
> > 
> > > > +    assert( p_aout->p_mixer );
> > >  I don't think this one is valid.
> > > >      aout_FifoInit( p_aout, &p_input->mixer.fifo,
> > > > p_aout->p_mixer->fmt.i_rate ); p_input->mixer.begin = NULL;
> > 
> > It is dereferenced
> > here                                              ^^
> I will check, but it is probably an error, and p_aout->mixer_format
> should be used instead (in the whole function).

I triggered this by playing a52 after removing spdif mixer module

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090903/d41b0817/attachment.sig>