[vlc-devel] [PATCH] Fix demuxdump to work with RTP input

[Marian Ďurkovič]

On Fri, Sep 04, 2009 at 12:16:56PM +0200, Rémi Denis-Courmont wrote:
> 
> On Fri, 4 Sep 2009 12:13:37 +0200, jpd at videolan.org wrote:
> > On Fri, Sep 04, 2009 at 11:49:29AM +0200, Marian ??urkovi?? wrote:
> >>   attached patch solves problem with demuxdump, which currently
> >> dumps garbage when RTP input is used. When stream_Read was used
> >> alone, it read 1316 bytes from the RTP input add added garbage upto
> >> DUMP_BLOCKSIZE. With stream_Peek it works as expected and also makes
> >> the whole demuxdump faster.
> > 
> > Looks ok to me, so applied, thanks. Would be nice to have this message
> > in the patch, saving me the copy/paste. :-)
> 
> To me, this looks like it's working around a bug somewhere else, which is
> bad.

Yes, the bug is most probably in RTP input since this is the only input
that doesn't work right with demuxdump.

Anyway, there was a comment for a long time saying stream_Peek is faster,
so I just implemented that idea and as a side effect it now works with
RTP input as well. 

We still have to find out, why RTP input doesn't pass input options like
":demuxdump-file=kkk" to demuxdump, while other inputs do it well.
It can be also workarounded by using "--demuxdump-file=kkk", which works
fine, but obviously the GUI is non-functional since it uses the : syntax.


      With kind regards,

              M.