[vlc-devel] [PATCH] Media library module for VLC, GSoC 09

[Barry Wardell]

Hi,

A couple of minor things I noticed which don't seem right:

diff --git a/include/vlc_interface.h b/include/vlc_interface.h
> index b8a43ae..2ab453c 100644
> --- a/include/vlc_interface.h
> +++ b/include/vlc_interface.h
> @@ -173,17 +173,34 @@ typedef enum vlc_dialog {
>                           "*.oga;*.ogg;*.oma;*.s3m;*.spx;" \
>                           "*.wav;*.wma;*.wv;*.xm"
>
> +#define EXTENSIONS_AUDIO_CSV "a52", "aac", "ac3", "ape", "dts", "flac",
> "it", \
> +                         "m4a", "m4p", "mka", "mlp", "mod", "mp1", "mp2",
> "mp3",\
> +                         "oga", "ogg", "oma", "s3m", "spx" \
> +                         "wav", "wma", "wv", "xm"
> +
>

This appears to be missing some extensions: aiff, aob, mpc.


>  #define EXTENSIONS_VIDEO
> "*.asf;*.avi;*.divx;*.dv;*.flv;*.gxf;*.iso;*.m1v;*.m2v;" \
> -
> "*.m2t;*.m2ts;*.m4v;*.mkv;*.mov;*.mp2;*.mp4;*.mpeg;*.mpeg1;" \
> -                         "*.mpeg2;*.mpeg4;*.mpg;*.mts;*.mxf;*.nuv;" \
> -                         "*.ogg;*.ogm;*.ogv;*.ogx;*.ps;" \
> -                         "*.rec;*.rm;*.rmvb;*.tod;*.ts;*.vob;*.wmv"
> +
> "*.m2t;*.m2ts;*.m4v;*.mkv;*.mov;*.mp2;*.mp4;*.mpeg;*.mpeg1;" \
> +                          "*.mpeg2;*.mpeg4;*.mpg;*.mts;*.mxf;*.nuv;" \
> +                          "*.ogg;*.ogm;*.ogv;*.ogx;*.ps;" \
> +                          "*.rec;*.rm;*.rmvb;*.ts;*.vob;*.wmv"
> +
>

Is this necessary? It removes *.tod.


> +#define EXTENSIONS_VIDEO_CSV "asf", "avi", "divx", "dv", "flv", "gxf",
> "iso", \
> +                             "m1v", "m2v", "m2t", "m2ts", "m4v", "mkv",
> "mov",\
> +                             "mp2", "mp4", "mpeg", "mpeg1", \
> +                             "mpeg2", "mpeg4", "mpg", "mts", "mxf", "nuv",
> \
> +                             "ogg", "ogm", "ogv", "ogx", "ps", \
> +                             "rec", "rm", "rmvb", "ts", "vob", "wmv"
>

Also missing the tod.


>  #define EXTENSIONS_PLAYLIST
> "*.asx;*.b4s;*.m3u;*.pls;*.ram;*.rar;*.vlc;*.xspf;*.zip"
>
> +#define EXTENSIONS_PLAYLIST_CSV "asx", "b4s", "m3u", "pls", "ram", "vlc",
> "xspf"
> +
>

Missing rar and zip.

Barry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090904/95c09019/attachment.html>