[vlc-devel] commit: qt4: selector: switch source on single click (Jakob Leben )

[Jean-Baptiste Kempf]

On Mon, Sep 07, 2009 at 01:45:04AM +0200, git version control wrote :
> qt4: selector: switch source on single click
No.

> +       Connecting itemClicked signal is easier, of course */

And broken.
You just broke all key activation.
Please revert.

> -    int i_type = item->data( 0, TYPE_ROLE ).toInt();
> +    QVariant type = item->data( 0, TYPE_ROLE );
> +    if( type == QVariant() ) return;
> +
> +    int i_type = type.toInt();
Why is that necessary?


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/