[vlc-devel] [PATCH] Fix demuxdump to work with RTP input

Marian Ďurkovič md at bts.sk
Tue Sep 8 08:53:26 CEST 2009

On Fri, 4 Sep 2009 12:47:37 +0200, Marian Ďurkovič wrote
> Anyway, there was a comment for a long time saying stream_Peek is 
> faster, so I just implemented that idea and as a side effect it now 
> works with RTP input as well.

Seems that comment was wrong. Now when stream_Read is fixed, I did a little
testing using a 1 Gig file in memory dumping do /dev/null and the average
results for 10 attempts are:

demuxdump with stream_Read: 1.79 s
demuxdump with stream_Peek: 1.83 s

stream_Peek calls block_ChainGather() at the end, which is more CPU expensive
than a simple memcopy.

We should probably revert this and remove the misleading comment.

   With kind regards,


More information about the vlc-devel mailing list