[vlc-devel] AC3 3F1R downmix to stereo (simple downmixer)

[James Turner]

I've encountered a problem where AC3 3F1R is being down-mixed to  
stereo incorrectly - VLC is selecting the 'trivial_mixer' instead of  
the 'simple_mixer', and hence discarding the centre channel, which  
happens to contain all the dialogue for the content in question.

This is occurring with 1.0.1 on both Mac and Windows (tested under  
VMWare).

 From browsing the source code to the simple mixer, I think this is a  
straightforward case of the channel layout in question (left/right/ 
centre/centre-rear) not being supported by the downmix code. The  
attached patch adds support to the simple downmixer - it works great  
for me, but I'm not 100% confident on the scaling factors applied to  
the sample values, and would welcome some advice there.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-simple-downmix.patch
Type: application/octet-stream
Size: 2717 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090908/df036eae/attachment.obj>
-------------- next part --------------



I'm not at all happy with the symbolic name I chose for the layout  
(AOUT_CHANS_4_CENTRE_REAR), feel free to pick a shorter/clearer/better  
name!

I made no attempt to support the 'output.i_physical_channels ==  
AOUT_CHANS_4_0' case in the patch, but I believe it's also  
straightforward if someone wished to do that.

Note this work was done on the 1.0 bugfix branch from git, since I  
encountered compile errors with trunk (on Mac 10.5, XCode 3.1.3).

Regards,
James