[vlc-devel] [PATCH] Removed non working function from Lua common module

Vicente Jiménez googuy at gmail.com
Thu Sep 10 13:56:54 CEST 2009


Could somebody confirm that he could use the JavaScript VLC's object
'callbacks'?
I think is something left from a previous version of VLC and now is
not defined and it always returns nill.
I couldn't find it any other reference in the current source code. So
it couln't be defined or initialized.

This is the reason for offering the previous patch. It removes the
function print_callbacks from share/http/modules/common.lua that never
returns anything because vlc.callbacks is not initialize anywhere in
the VLC source code.

I could resent the patch.

On Thu, Aug 20, 2009 at 2:07 PM, Vicente Jiménez <googuy at gmail.com> wrote:
> The function that I'd tried to use is print_callbacks in modules/common.lua.
> (The one that this patch removes)
>
>> I've tried to use this function and I get an error because
>> vlc.callbacks is nil instead of a table.
>> I've also tried to use vlc.callbacks directly in Lua and look for
>> vlc.callbacks object definition in the source code without success.
>>
>> Could anybody point me how to use this function or where to look in
>> the source code?
>> Otherwise, if I'm right and vlc.callbacks doesn't exist as a Lua VLC
>> extension, please, apply the patch.
>>
>> Thanks
>>
>> On Mon, Aug 3, 2009 at 10:53 AM, Antoine Cellerier<dionoea at videolan.org> wrote:
>>> On Fri, Jul 31, 2009, Vicente Jiménez wrote:
>>>> It's really a question:
>>>> is vlc.callbacks valid in Lua?
>>>> It's not documented and I haven't found any (other) reference in source code.
>>>> If it's not valid then the attached patch could be of interest.
>>>
>>> The vlc.callbacks variable is used internally by VLC to store lua
>>> callbacks registered on VLC variables. It's kind of a hack. Anyway,
>>> removing that print function from the lua code looks fine to me.
>>>
>>> Regards,
>>>
>>> --
>>> Antoine Cellerier
>>> dionoea
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> http://mailman.videolan.org/listinfo/vlc-devel
>>>
>>
>



More information about the vlc-devel mailing list