[vlc-devel] [PATCH] vlm and vod preparsing

Rémi Denis-Courmont remi at remlab.net
Mon Sep 14 11:16:47 CEST 2009




On Mon, 14 Sep 2009 11:13:17 +0200, Sébastien Escudier
<sebastien-devel at celeos.eu> wrote:
> Quoting Rémi Denis-Courmont <remi at remlab.net>:
> 
>> There is a small window of opportunity for a dead lock here. If you
> signal
>> the
>> condition while the VLM thread is not in vlc_cond_wait(), the wake up
> will be
>> lost. Then the VLM thread will sleep for all eternity.
> 
> Ok, I can add a lock in the callback, it should be ok now ?
> Attached, my two patches updated.

A lone semaphore would be more compact than a lock plus a condition
variable.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list