[vlc-devel] commit: mozilla plugin: fix potential buffer overlow. ( Rémi Duraffort )

[Anthony Loiseau]

Hi,

I think this commit insert a mistake on stop statement. Attached is an
untested fix for this commit (which I didn't test neither. Just checked
the fact with a foo test program).

If the fix goes into master branch, you would maybe want to back-port it
since the commit it fixes have been back-ported to 1.0-bugfix too.

Regards.
Anthony

On Tue, 2009-09-15 at 21:33 +0200, git version control wrote:
> vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Tue Sep 15 21:23:09 2009 +0200| [c49f925211b168459ac43d4113c3aedeb587f052] | committer: Rémi Duraffort 
> 
> mozilla plugin: fix potential buffer overlow.
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c49f925211b168459ac43d4113c3aedeb587f052
> ---
> 
>  projects/mozilla/vlcplugin.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/projects/mozilla/vlcplugin.cpp b/projects/mozilla/vlcplugin.cpp
> index 80ddbd5..d1e82e1 100644
> --- a/projects/mozilla/vlcplugin.cpp
> +++ b/projects/mozilla/vlcplugin.cpp
> @@ -134,7 +134,7 @@ NPError VlcPlugin::init(int argc, char* const argn[], char* const argv[])
>      const char *progid = NULL;
>  
>      /* parse plugin arguments */
> -    for( int i = 0; i < argc ; i++ )
> +    for( int i = 0; i < argc , ppsz_argc < 32; i++ )
>      {
>         /* fprintf(stderr, "argn=%s, argv=%s\n", argn[i], argv[i]); */
>  

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-mozilla-fix-stop-condition-of-a-for-iteration.patch
Type: text/x-patch
Size: 1484 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090916/a29a3d43/attachment.bin>