[vlc-devel] [PATCH] Sqlite Module for VLC, GSoC 09

[Pierre d'Herbemont]

On Sep 15, 2009, at 8:28 PM, Laurent Aimar wrote:

>> +        vlc_object_release( p_sql );
>> +        msg_Err( p_this, "SQL provider not found" );
>> +        return NULL;
>> +    }
>> +
>> +    vlc_object_set_destructor( p_sql, __sql_Destructor );
> I am not sure that using vlc_object_set_destructor instead of a  
> dedicated
> function to destroy a sql_t object is good.
> At least with a dedicated function, it is easier to track when an  
> object is
> created and destroyed.
> Besides, a sql_t object will not be shared and so I don't think the  
> refcounting
> here is a good thing, it might give bad ideas to people.
> I would like to hear the opinions of other people on this one.

Either way, vlc_object_hold() still exists, and its current name and  
definition is misleading. But I think we've already been on that. I  
just sent a RFC with some changes we could make to force us to clarify  
the situation.

Pierre.