[vlc-devel] RE : [Re:] [vlc-commits] commit: Qt: delete unneeded MenuItemData (Jakob Leben )

[Jakob Leben]

On Sat, Apr 3, 2010 at 1:26 PM, brezhoneg1 <brezhoneg1 at yahoo.fr> wrote:

>
> >
> > >Qt: delete unneeded MenuItemData (Jakob Leben
> > >eacddb63e8a5bda42395ee79b5b27db6408] | committer: Jakob Leben
> > >
> > >Qt: delete unneeded MenuItemData
> > >
>


> > This patch was singled out as the one causing a regression
> > for skins2 (a user of qt4 menus),  namely skins2 yet again
> > crashing at exit on both win32 and Linux.
> >
> > When using qFindChild, are we sure there is a unique direct
> > child for an action ? Technically, there could be multiple
> > ones, in which case the one being deleted
> > is may still be addressed elsewhere.  (qt4 doc seems to say
> > it is undefined in this case)
> >
> > As a matter of fact, just reverting this patch does solve the problem.
> >
> > Was this patch correcting a specific issue or just intended
> > as a cosmetic ?
> >
> > Regards
> > Erwan10
>
> Edit: the qt4 interface has got the very same problem
>  - start vlc -I qt
>  - exit via the popupmenu (rightclick on mouse)
> vlc then crashes.
>

Hi, I will look at this problem this evening. Thanks for reporting!

Jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100405/648f1511/attachment.html>