[vlc-devel] [vlc-commits] commit: qt4: Don't create QMenu without parents (Erwan Tulou )

[brezhoneg1]

--- En date de : Mar 6.4.10, Jean-Baptiste Kempf <jb at videolan.org> a écrit :

> De: Jean-Baptiste Kempf <jb at videolan.org>
> Objet: Re: [vlc-devel] [vlc-commits] commit: qt4: Don't create QMenu without parents (Erwan Tulou )
> À: vlc-devel at videolan.org
> Cc: vlc-commits at videolan.org
> Date: Mardi 6 avril 2010, 16h58
> On Tue, Apr 06, 2010 at 04:56:06PM
> +0200, git at videolan.org
> wrote :
> > vlc | branch: master | Erwan Tulou <erwan10 at videolan.org>
> | Tue Apr  6 16:40:11 2010 +0200|
> [8d8bd80666aff8073f1ccd37a41cd1786096b0c3] | committer:
> Erwan Tulou 
> > 
> > qt4: Don't create QMenu without parents
> > 
> 
> There is NO reason that this root object needs to be a
> QWidget except to
> introduce visual artefacts.
> 
> Parenting is a feature of QObject, not of QWidget
> 
> 

It depends. QAction expects a QObject parent, but QMenu expects a QWidget parent (at least in Qt4.4)

As for artefacts, as long as it is non visible widget attached to no layout, it is just a memory structure. There should be no visual problem.

Regards
Erwan10