[vlc-devel] [vlc-commits] commit: qt4: Don't create QMenu without parents (Erwan Tulou )

[brezhoneg1]

--- En date de : Mar 6.4.10, Jean-Baptiste Kempf <jb at videolan.org> a écrit :

> De: Jean-Baptiste Kempf <jb at videolan.org>
> Objet: Re: [vlc-devel] [vlc-commits] commit: qt4: Don't create QMenu without parents (Erwan Tulou )
> À: "Mailing list for VLC media player developers" <vlc-devel at videolan.org>
> Date: Mardi 6 avril 2010, 17h33
> On Tue, Apr 06, 2010 at 05:25:26PM
> +0200, Jakob Leben wrote :
> > In my opinion, this commit is unnecessary bloat. All
> that was needed to fix
> 
> I don't like this commit either.
> 
> 

The thing is there are not many solutions

  - QMenu needs a QWidget as parent
  - dialog_provider (as a dialog provider only) doesn't have any widget
  - Leaving QMenu without parent is just plain memory leak, and leads to vlc objects leak at times.


Rgds
Erwan10