[vlc-devel] [vlc-commits] commit: qt4: Don't create QMenu without parents (Erwan Tulou )

Francois Cartegnie fcvlcdev at free.fr
Wed Apr 7 17:27:07 CEST 2010


Le mercredi 7 avril 2010, vous avez écrit :
> The p_popup_menu right now is effectively a singleton design. In the light
> of your remarks, we just move p_popup_menu to QVLCMenu, as it's static
> member.

Didn't realized that QVLCMenu was an existing class name.
As it's not a Menu itself, a nice thing would be to rename it to 
QVLCMenuManager or QVLCMenuProvider to effectively reflect what it's used for.

Francois



More information about the vlc-devel mailing list