[vlc-devel] Revert please commit Block setlocale() f0d55dabe9747009d296e251bda7dc2f812bb077

[Rémi Denis-Courmont]

On Tue, 13 Apr 2010 16:00:11 +0300, Ivanich <spams at ivanich.od.ua> wrote:
> [0x9aa64e0] main audio output debug: looking for audio output module: 4
> candidates
> Blocked: call to setlocale(1, "C")
> Blocked: call to setlocale(1, "ru_RU.UTF-8")
> Blocked: call to setlocale(1, "C")
> Blocked: call to setlocale(1, "ru_RU.UTF-8")
> ALSA lib pcm_route.c:1015:(snd_pcm_route_load_ttable) Invalid type for 4
> [0x9aa64e0] alsa audio output debug: failed to find a usable ALSA
> configuration
> [0x9aa64e0] alsa audio output debug: Available alsa output devices:
> [0x9aa64e0] alsa audio output debug:   HDA Intel: ALC883 Analog (hw:0,0)
> [0x9aa64e0] alsa audio output debug:   HDA Intel: ALC883 Digital (hw:0,1)
> [0x9aa64e0] main audio output debug: thread (aout) created at priority 15
> (oss.c:516)
> [0x9aa64e0] main audio output debug: using audio output module "oss"
> 
> This commit breaks alsa.

Changing the locale at this point can make the process crash. This is not
theoretic. I have observed such crashes (live555 changed the locale to
print floating point numbers in American format).

A library is not allowed to call setlocale(). If you want to change the
thread locale, use uselocale(). Please fix ALSA.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis