[vlc-devel] [PATCH 1/8] fix unsupported shortcut

Rémi Denis-Courmont remi at remlab.net
Wed Apr 14 17:53:10 CEST 2010


Le mercredi 14 avril 2010 18:09:30 Francois Cartegnie, vous avez écrit :
> Le mercredi 14 avril 2010, Jean-Baptiste Kempf a écrit :
> > On Wed, Apr 14, 2010 at 04:53:13PM +0200, Francois Cartegnie wrote :
> > >              memcpy( e.p_class, p_class, 4 );
> > >              memcpy( e.p_fourcc, p->p_fourcc, 4 );
> > > -            e.psz_description = p->psz_description ?: psz_description;
> > > +            if ( p->psz_description != NULL )
> > > +		e.psz_description = p->psz_description;
> > > +            else
> > > +		e.psz_description = psz_description;
> > >              break;
> >
> > Why not
> > e.psz_description = p->psz_description ? p->psz_description :
> >  psz_description;
> 
> The supported compact test & 80 chars split would be on 2 lines, so why not
> using the regular syntax ?

Because it takes 4 lines.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list