[vlc-devel] [PATCH] VLM deadlock regression

Rémi Denis-Courmont remi at remlab.net
Thu Apr 15 09:15:15 CEST 2010


On Thu, 15 Apr 2010 08:41:28 +0200, Sébastien Escudier
<sebastien-devel at celeos.eu> wrote:
> I am trying to fix a deadlock regression in VLM. It would be nice to fix
> this before 1.1
> You can find a short description of the deadlock here :
> http://mailman.videolan.org/pipermail/vlc-devel/2010-March/074155.html
> 
> Please review this patch.
> Note that I had to add the boolean in case an input dies while the manage
> thread is not in waiting state.

The original code seems broken and the patch does not seem to fix it.

Raising a signal on a condition variable with no state can't be right. I
see this in multiple places.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis




More information about the vlc-devel mailing list