[vlc-devel] [PATCH] Fix segfault on preparser

[Rémi Denis-Courmont]

Le jeudi 15 avril 2010 20:33:53 Francois Cartegnie, vous avez écrit :
> ---
>  src/playlist/preparser.c |   12 ++++++++++--
>  1 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/src/playlist/preparser.c b/src/playlist/preparser.c
> index 9dbc15d..62b9502 100644
> --- a/src/playlist/preparser.c
> +++ b/src/playlist/preparser.c
> @@ -175,8 +175,16 @@ static void Art( playlist_preparser_t *p_preparser,
>  input_item_t *p_item ) }
>          else
>          {
> -            msg_Dbg( p_playlist, "no fetch required for %s (art currently
>  %s)", -                     psz_name, psz_arturl );
> +            if ( psz_arturl && psz_name )
> +            {
> +                msg_Dbg( p_playlist, "no fetch required for %s (art
>  currently %s)", +                        psz_name, psz_arturl );
> +            }
> +            else
> +            {
> +	        /* We shouldn't get there */
> +                msg_Err( p_playlist, "no valid meta combination found" );
> +            }

I agree there is a bug, but the fix is rather nasty. What if only one of the 
value is non NULL (which is quite frequent).

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis