[vlc-devel] [PATCH] Added support for VDR recordings.

[Tobias Güntner]

Am 17.04.2010 15:48, schrieb Rémi Denis-Courmont:
> Correction. You did not enable non-blocking mode. You had enabled non-bocking
> open(). In my understanding, this does not propagate to the file descriptor;
> it merely prevents the open() call from blocking. This is more commonly done
> with O_NDELAY (which is a synomym). It is often combined with O_NOCTTY.

`man 2 open` says:
O_NONBLOCK or O_NDELAY
When possible, the file is opened in non-blocking mode. Neither the 
open() nor any subsequent operations on the file descriptor which is 
returned will cause the calling process to wait. ...

> file.c does that so that the thread does not freeze when trying to open a pipe
> or a character device.
>
> That said, the check for EAGAIN error from read() was still useless anyway.
> And so would have been non-blocking mode.

Removed in the third patch.

-- 
Regards,
Tobias Güntner