[vlc-devel] [PATCH] globalhotkeys misdetecs usage of OLD XCB API if --enable-xcb is not specified

Dominique Leuenberger dominique at leuenberger.net
Sun Apr 25 11:13:56 CEST 2010


As there was a change in the XCB_KEYSYMS API, configure had been  
extended to follow this change, by adding CFLAGS in case of old  
XCB_KEYSYMS being detected. Unfortunately this was only done in case  
--enable-xcb had been specified.

But the globalhotkeys plugin has it's own detection of xcb /  
xcb-keysysms in configure and as such this module did not get the  
OLD_XCBKEYSYM_API flag specified, which resulted in a build failure on  
my system.

The patch below introduces as additional check for globalhotkeys to  
also catch when to use the old API.

I think it would be great to merge this with the 1.0-bugfix tree, in  
case we have any future releases in this tree (who knows).

Best Regards,
Dominique, a.k.a DimStar

PS: Thanks everybody for the patience with me trying to track this down.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-globalhotkey-with-old-xcb-keysyms.patch
Type: text/x-patch
Size: 747 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100425/46e69fb5/attachment.bin>

More information about the vlc-devel mailing list